Icecast Streaming Media Server

[unnamed_devel]

Hi anybody who developed icecast v2 !

I love him but want to implement some really need for me stats globally

total_bytes_read_over_server
total_bytes_sent_over_server

how can i implement this?

learning sources i found source.c as a injection starting point.
static get_next_buffer()
{
.....
if (current >= source->client_stats_update)
{
stats_event_args (source->mount, "total_bytes_read",
FORMAT_UINT64, source->format->read_bytes);
stats_event_args (source->mount, "total_bytes_sent",
FORMAT_UINT64, source->format->sent_bytes);
source->client_stats_update = current + 5;

//MY (PROBABLY) ADDITION
char *sval=stats_get_value(NULL, "tot_bytes_read");
uint64_t ival= atol(sval) + source->format->read_bytes;
stats_event_args (NULL, "tot_bytes_read", FORMAT_UINT64, ival);
sval=stats_get_value(NULL, "tot_bytes_sent");
ival= atol(sval) + source->format->sent_bytes;
stats_event_args (NULL, "tot_bytes_sent", FORMAT_UINT64, ival);
}
.....
}


but i got incorrect stats over server. (((

how i can CORRECTLY implements required stats?

[karlH]

The section you are referring to is actually per-source, but you are updating stats globally, so it's not an accumulation of all streams. I've done some tweaking to my latest branch work to show the total sent by all streams. http://mediacast1.com/~karl/icecast-2.3-kh4.tar.gz
let me know if 'stream_kbytes_sent' is what you expect, that bit could be merged easily.

karl.

[unnamed_devel]

KarlH eeeeahhh!!! Love you more!

This is what i expected!
I've looked at your source and make some patch for icecast 2.3.1 source tree.
U give me an idea how to implement this :) thx for advice!

i can upload or send you my sources. and you 'diff' at em :)
My addons is:

per source count :
+total LISTENERS HITS (only listeners)
per server (or server-wide):
+total traffic out
+total traffic in
+current listeners (ONLY listeners!)

changes sources:
auth.c
function add_client_to_source
{
....
stats_event_inc (NULL, "listener_connections");

//NEW
stats_event_inc (source->mount, "listenershits")

//CONTINUE
if (source->running == 0 && source->on_demand)
....
}



source.c
function source_clear_source
{
....
source->client_stats_update = 0;

//NEW
source->bytes_read_since_update=0;
source->bytes_sent_since_update=0;

//CONTINUE
util_dict_free (source->audio_info);
....
}


function get_next_buffer
{
...
if (current >= source->client_stats_update)
{
//NEW
stats_event_add (NULL, "tot_kbytes_read", (source->format->read_bytes - source->bytes_read_since_update)/1024);
source->bytes_read_since_update=source->format->read_bytes;
stats_event_add (NULL, "tot_kbytes_sent", (source->format->sent_bytes - source->bytes_sent_since_update)/1024);
source->bytes_sent_since_update=source->format->sent_bytes;

//CONTINUE
stats_event_args (source->mount, "total_bytes_read",
FORMAT_UINT64, source->format->read_bytes);
...
}


function source_init
{
....
stats_event_args (source->mount, "listeners", "%lu", source->listeners);

//NEW
stats_event (source->mount, "listenershits", "0");

//CONTINUE
stats_event_args (source->mount, "listener_peak", "%lu", source->peak_listeners);
....
}



function source_main
{
....
avl_delete(source->client_tree, (void *)client, _free_client);

//NEW
stats_event_dec (NULL, "listeners");

//CONTINUE
source->listeners--;
DEBUG0("Client removed");
....
....
avl_insert(source->client_tree, client_node->key);

//NEW
stats_event_inc (NULL, "listeners");

//CONTINUE
source->listeners++;
DEBUG0("Client added");
....
}

[karlH]

I'm not so sure about the stats name "listenershits", doesn't read quite right

An accumulated listener count per-source should really be added and a similar global stat for total read is ok.

karl.

[unnamed_devel]

"listenershits" is accumulate client audio players hits. some simular to web browsers hits on WWW-servers

an example:
initially listenershits=0 (on source creation)

now connect at mount http://server:port/mount (NOT PLAYLIST(!), ONLY REAL REQUEST FOR THAT STREAM!)
listenershists will be 1

now disconnect and connect ...hmm five times again.
listenershits will be 6
(1+5)

and this statistics needed _per all sources_


anyway, KarlH thx for all